Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate key labels of rb/crb #4811

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Deprecate key labels of rb/crb #4811

merged 1 commit into from
Apr 10, 2024

Conversation

whitewindmills
Copy link
Member

@whitewindmills whitewindmills commented Apr 8, 2024 •
edited by RainbowMango
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

resourcebinding.karmada.io/key -> resourcebinding.karmada.io/permanent-id
clusterresourcebinding.karmada.io/key -> clusterresourcebinding.karmada.io/permanent-id

Which issue(s) this PR fixes:
part of #4711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: The labels `resourcebinding.karmada.io/key` and `clusterresourcebinding.karmada.io/key` has been deprecated and not be populated in Work objects(replaced by `resourcebinding.karmada.io/permanent-id` and `clusterresourcebinding.karmada.io/permanent-id` respectively).

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 8, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2024
@whitewindmills
Copy link
Member Author

Split from #4743.
/cc @RainbowMango

@RainbowMango
Copy link
Member

Split from #4743. /cc @RainbowMango

Nice, I like small PRs. Thanks. I'll work on this then #4743.

@RainbowMango
Copy link
Member

Re-run the test as the failure seems not related:

Error: operator/pkg/util/util.go:20:2: read /opt/hostedtoolcache/go/1.21.8/x64/src/archive/tar/example_test.go: unexpected NUL in input

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Apr 8, 2024
Open
30 tasks
@XiShanYongYe-Chang
Copy link
Member

/assign

RainbowMango
RainbowMango reviewed Apr 9, 2024
View reviewed changes
pkg/util/helper/work.go Outdated Show resolved Hide resolved
pkg/dependenciesdistributor/dependencies_distributor.go Show resolved Hide resolved
pkg/dependenciesdistributor/dependencies_distributor.go Outdated Show resolved Hide resolved
pkg/controllers/binding/common.go Outdated Show resolved Hide resolved
pkg/apis/work/v1alpha1/well_known_constants.go Outdated Show resolved Hide resolved
pkg/apis/work/v1alpha1/well_known_constants.go Outdated Show resolved Hide resolved
@RainbowMango
Copy link
Member

I updated the release notes a little bit, by the way.

@whitewindmills whitewindmills force-pushed the deprecated-rb_crb-labels branch 2 times, most recently from 9676a16 to c9f3f8e Compare April 10, 2024 02:30
@whitewindmills
Deprecate key labels of rb/crb
f8d6be5 
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
RainbowMango
RainbowMango approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Leave LGTM to @XiShanYongYe-Chang for another look.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@karmada-bot karmada-bot merged commit 4898c0f into karmada-io:master Apr 10, 2024
12 checks passed
@RainbowMango
Copy link
Member

What's the next PR I can help with?

@whitewindmills
Copy link
Member Author

What's the next PR I can help with?

thanks, #4743 still needs your review.

@RainbowMango
Copy link
Member

Got it.

@RainbowMango RainbowMango mentioned this pull request Apr 11, 2024
Merged
@whitewindmills whitewindmills deleted the deprecated-rb_crb-labels branch April 19, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@Poor12 Poor12 Awaiting requested review from Poor12

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@whitewindmills @RainbowMango @XiShanYongYe-Chang @karmada-bot