add ut for WorkloadRebalancer controller #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/failing-test
karmada-bot
added
the
size/L
chaosi-zju
force-pushed
the
reschedule-ut
branch
from
d541657
to
87bbfe8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4876 +/- ##
==========================================
+ Coverage 53.13% 53.17% +0.04%
==========================================
Files 251 252 +1
Lines 20415 20525 +110
==========================================
+ Hits 10847 10914 +67
- Misses 8854 8892 +38
- Partials 714 719 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chaosi-zju
force-pushed
the
reschedule-ut
branch
from
87bbfe8
to
6634df1
Compare
|
/hold |
karmada-bot
added
the
do-not-merge/hold
|
/hold cancel |
karmada-bot
removed
the
do-not-merge/hold
chaosi-zju
force-pushed
the
reschedule-ut
branch
2 times, most recently
from
2d9a125
to
61b24fe
Compare
pkg/controllers/workloadrebalancer/workloadrebalancer_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/workloadrebalancer/workloadrebalancer_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/workloadrebalancer/workloadrebalancer_controller_test.go
Show resolved
Hide resolved
RainbowMango
reviewed
May 8, 2024
pkg/controllers/workloadrebalancer/workloadrebalancer_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/workloadrebalancer/workloadrebalancer_controller_test.go
Outdated
Show resolved
Hide resolved
|
is there any more comments? |
|
/assign |
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until the following PR have been merged:
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
add ut for WorkloadRebalancer controller
Which issue(s) this PR fixes:
Fixes part of #4840
Special notes for your reviewer:
Does this PR introduce a user-facing change?: