ObjectWatcher.Delete checks if resource can be deleted #4880
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/M
|
Thanks @whitewindmills |
|
Ask @chaunceyjiang to help take a review. |
whitewindmills
force-pushed
the
objectwatcher-delete
branch
from
07310cb
to
032f827
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4880 +/- ##
==========================================
+ Coverage 53.07% 53.08% +0.01%
==========================================
Files 251 251
Lines 20389 20389
==========================================
+ Hits 10821 10824 +3
+ Misses 8855 8852 -3
Partials 713 713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
whitewindmills
force-pushed
the
objectwatcher-delete
branch
from
032f827
to
f9f3d47
Compare
| klog.Infof("Abort deleting the resource(kind=%s, %s/%s) exists in cluster %v but not managed by karmada", clusterObj.GetKind(), clusterObj.GetNamespace(), clusterObj.GetName(), clusterName) | ||
| return nil | ||
| } | ||
| util.MergeLabel(workload, workv1alpha2.WorkPermanentIDLabel, util.GetLabelValue(work.Labels, workv1alpha2.WorkPermanentIDLabel)) |
There was a problem hiding this comment.
This line appears to have been deleted.
There was a problem hiding this comment.
we don't need it anymore, it's never be used.
There was a problem hiding this comment.
That's actually what I was wondering too. Why did it need to be added before? 🙈
There was a problem hiding this comment.
🤯 I have to admit it was my mistake.
There was a problem hiding this comment.
I was surprised with this line, that's the reason why I always ask for small PRs.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Split from #4813.
See #4813 (comment)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: