chore: fix ghaction APIServer compatibility #4897
Conversation
…ity. Signed-off-by: Lan Liang <gcslyp@gmail.com>
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4897 +/- ##
==========================================
- Coverage 53.13% 53.12% -0.02%
==========================================
Files 251 251
Lines 20417 20417
==========================================
- Hits 10849 10846 -3
- Misses 8855 8857 +2
- Partials 713 714 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -52,7 +43,7 @@ jobs: | |||
| - name: install Go | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: ${{ matrix.go-version }} | |||
| go-version-file: go.mod | |||
There was a problem hiding this comment.
It will use the latest patch release, like:
- For release-1.9 uses go1.20.14
- For release-1.8 uses go1.20.14
- For release-1.7 uses go1.20.14
It is acceptable I think.
| @@ -83,7 +74,7 @@ jobs: | |||
| if: always() | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: karmada_e2e_log_${{ matrix.k8s }} | |||
| name: karmada_e2e_log_${{ matrix.kubeapiserver-version }}_${{ matrix.karmada-version }} | |||
…rsion. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
force-pushed
the
fix_ghaction_compatibility
branch
from
a629430
to
f11ec8b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
there are two changes:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: