Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e for FederatedHPA and metrics-adapter #4903

Merged
merged 1 commit into from
May 13, 2024
Merged

add e2e for FederatedHPA and metrics-adapter #4903

merged 1 commit into from
May 13, 2024

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e for FederatedHPA and metrics-adapter.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label May 6, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2024
@chaosi-zju
Copy link
Member Author

chaosi-zju commented May 6, 2024 •
edited

@chaunceyjiang can you help reviewing this PR?

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.17%. Comparing base (4ccffcc) to head (b3ccd3b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
- Coverage   53.18%   53.17%   -0.02%     
==========================================
  Files         252      252              
  Lines       20510    20510              
==========================================
- Hits        10909    10906       -3     
- Misses       8882     8884       +2     
- Partials      719      720       +1
Flag Coverage Δ
unittests 53.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju chaosi-zju mentioned this pull request May 8, 2024
Merged
@chaosi-zju chaosi-zju force-pushed the fedhpa-e2e branch 2 times, most recently from a8d7ccb to b25e046 Compare May 8, 2024 06:47
@chaosi-zju chaosi-zju force-pushed the fedhpa-e2e branch 3 times, most recently from be69441 to fa498e9 Compare May 9, 2024 04:32
@chaosi-zju
Copy link
Member Author

ready

cc @RainbowMango

@RainbowMango
Copy link
Member

cc test owners
/assign @XiShanYongYe-Chang @Vacant2333

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed May 11, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

test/e2e/federatedhpa_test.go Outdated Show resolved Hide resolved
test/e2e/federatedhpa_test.go Outdated Show resolved Hide resolved
test/e2e/federatedhpa_test.go Outdated Show resolved Hide resolved
test/e2e/federatedhpa_test.go Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

@XiShanYongYe-Chang comments all fixed.

@chaosi-zju chaosi-zju force-pushed the fedhpa-e2e branch 2 times, most recently from d7cf04b to aa07487 Compare May 13, 2024 01:23
@chaosi-zju
add e2e for FederatedHPA and metrics-adapter.
b3ccd3b 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed May 13, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@karmada-bot karmada-bot merged commit 499608f into karmada-io:master May 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@Vacant2333 Vacant2333

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@chaosi-zju @codecov-commenter @RainbowMango @karmada-bot @chaunceyjiang @XiShanYongYe-Chang @Vacant2333