-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kind to v0.22.0 #4909
Bump kind to v0.22.0 #4909
Conversation
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update kind_version
to v0.22.0?, checking at hack/xxxx
Yes, here: karmada/hack/local-up-karmada.sh Line 82 in 34c4d04
|
Two more places: karmada/.github/workflows/cli.yaml Line 39 in 7071e1f
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4909 +/- ##
=======================================
Coverage 53.13% 53.13%
=======================================
Files 251 251
Lines 20415 20415
=======================================
Hits 10848 10848
Misses 8853 8853
Partials 714 714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
33b6e84
to
98cb2a9
Compare
@RainbowMango @liangyuanpeng thanks, ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@liangyuanpeng Do you want to take another look?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the kind and pin to the released version.
Which issue(s) this PR fixes:
part of #4907
Special notes for your reviewer:
Does this PR introduce a user-facing change?: