Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kind to v0.22.0 #4909

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

whitewindmills
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR updates the kind and pin to the released version.

Which issue(s) this PR fixes:
part of #4907

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 7, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2024
@whitewindmills
Copy link
Member Author

/cc @RainbowMango

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update kind_version to v0.22.0?, checking at hack/xxxx

@RainbowMango
Copy link
Member

Yes, here:

kind_version=v0.20.0

@RainbowMango
Copy link
Member

Two more places:

version: "v0.20.0"

KIND_VERSION: v0.20.0

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.13%. Comparing base (167f213) to head (98cb2a9).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4909   +/-   ##
=======================================
  Coverage   53.13%   53.13%           
=======================================
  Files         251      251           
  Lines       20415    20415           
=======================================
  Hits        10848    10848           
  Misses       8853     8853           
  Partials      714      714           
Flag Coverage Δ
unittests 53.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
@whitewindmills
Copy link
Member Author

@RainbowMango @liangyuanpeng thanks, ptal

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@liangyuanpeng Do you want to take another look?

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@liangyuanpeng
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@karmada-bot karmada-bot merged commit b38d4e4 into karmada-io:master May 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants