Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/cluster-api to v1.7.1 #4923

Merged
merged 1 commit into from
May 10, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Bump sigs.k8s.io/cluster-api to v1.7.1

Which issue(s) this PR fixes:
Parts of #4907

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 9, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (3fc8ef5) to head (ac6a8d4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4923      +/-   ##
==========================================
- Coverage   53.14%   53.14%   -0.01%     
==========================================
  Files         251      251              
  Lines       20415    20415              
==========================================
- Hits        10850    10849       -1     
- Misses       8852     8853       +1     
  Partials      713      713              
Flag Coverage Δ
unittests 53.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Please @XiShanYongYe-Chang help to take another look, I'm not sure if there is E2E test for cluster API feature.
/assign @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@XiShanYongYe-Chang
Copy link
Member

The cluster-api has not been added to the E2E environment. Therefore, there is no E2E to monitor this function.

We can test it by referring to the steps in #594

@zhzhuang-zju
Copy link
Contributor Author

The cluster-api has not been added to the E2E environment. Therefore, there is no E2E to monitor this function.

We can test it by referring to the steps in #594

get it, thanks. I'll test it later and post the verification results.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm

@XiShanYongYe-Chang
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@karmada-bot karmada-bot merged commit 8347d6a into karmada-io:master May 10, 2024
12 checks passed
@RainbowMango
Copy link
Member

get it, thanks. I'll test it later and post the verification results.

How is the test result?

@zhzhuang-zju
Copy link
Contributor Author

How is the test result?

Clusters created by cluster-api were successfully managed to karmada.

(base) ➜  karmada git:(main) ✗  kubectl get cluster
NAME              CLUSTERCLASS   PHASE         AGE   VERSION
capi-quickstart   quick-start    Provisioned   12h   v1.29.2
(base) ➜  karmada git:(main) ✗ kubectl --context karmada-apiserver get cluster
NAME              VERSION   MODE   READY   AGE
capi-quickstart   v1.29.2   Push   True    12h
member1           v1.27.3   Push   True    16h
member2           v1.27.3   Push   True    16h
member3           v1.27.3   Pull   True    16h

@RainbowMango
Copy link
Member

OK. got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants