Bump golangci-lint to v1.58.0 #4930
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
requested review from
carlory,
chaosi-zju,
chaunceyjiang,
Garrybest,
huntsman-li,
iawia002,
ikaven1024,
jwcesign,
lonelyCZ,
mrlihanbo,
Poor12,
prodanlabs,
Vacant2333,
whitewindmills,
wuyingjun-lucky and
XiShanYongYe-Chang
karmada-bot
added
the
size/L
|
since this is the last task, so i think you can fix the issue with |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4930 +/- ##
=======================================
Coverage 53.18% 53.19%
=======================================
Files 252 252
Lines 20510 20510
=======================================
+ Hits 10909 10911 +2
+ Misses 8882 8880 -2
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/helper/request.go
Outdated
| @@ -82,6 +82,7 @@ func DoRequest(urlPath string, token string) (int, error) { | |||
|
|
|||
| // #nosec | |||
There was a problem hiding this comment.
Do we not need this line anymore?
There was a problem hiding this comment.
Yes, it's no longer needed. I'll remove it.
There was a problem hiding this comment.
Does this PR need to wait for #4934?
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
zhzhuang-zju
force-pushed
the
golangciwith1.58.0
branch
from
5be8db3
to
309c677
Compare
| ObjectMeta: metav1.ObjectMeta{ | ||
| Annotations: map[string]string{corev1.ServiceAccountUIDKey: uuid}, | ||
| }, | ||
| Data: map[string][]byte{key: []byte(value)}, |
There was a problem hiding this comment.
Can you remind me why ObjectMeta and Data are required here?
There was a problem hiding this comment.
Function retainSecretServiceAccountToken is used to retain the uid and data of observed secret when its type is SA. Therefore the input secret of its test case should contain ObjectMeta(for uid) and Data. The previous implementations didn't actually test the ability to retain uid and data, because ObjectMeta and Data weren't used when creating test case secrets
There was a problem hiding this comment.
Got it, thanks.
@XiShanYongYe-Chang I'm not sure if you have to revisit this test at #4940 after this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump golangci-lint to v1.58.0. The following tasks are included：
golangci-lintversion inhack/verify-staticcheck.shrun.skip-dirsis deprecated, useissues.exclude-dirsinstead.run.skip-dirs-use-defaultis deprecated, useissues.exclude-dirs-use-defaultinstead.Which issue(s) this PR fixes:
Fixes #4907
Special notes for your reviewer:
Does this PR introduce a user-facing change?: