-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove propagationpolicy controller #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In so, the propagationpolicy controller
has no processing logic. How about removing this controller, @RainbowMango ?
Yes. We can totally remove this controller now. |
Signed-off-by: zhongjun.li <zhongjun.li@daocloud.io>
@RainbowMango The PropagationPolicy Controller has been deleted, PTAL /kind feature |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This logic is already in detector
![企业微信截图_8a9162b9-7b56-4ee0-99f7-2f87f59eb1a7](https://user-images.githubusercontent.com/39400425/139820002-b714d784-8890-4d1b-85fa-9f657cf0ab64.png)
Does this PR introduce a user-facing change?: