add killercoda example: install karmada through CLI #2

JadeFlute0127 · 2023-03-30T13:07:35Z

Signed-off-by: [JadeFlute0127] [1635468471@qq.com]

What this PR does / why we need it:
add killercoda example: install karmada through CLI

Which issue(s) this PR fixes:
Part of #1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

karmada-bot · 2023-03-30T13:07:45Z

Welcome @JadeFlute0127! It looks like this is your first PR to karmada-io/playground 🎉

jwcesign · 2023-03-31T01:37:53Z

Please replace the word Fix with Part of.

jwcesign

Great job! Just some nits.
We currently do not require the killercoda-sample directory.

killercoda-sample/karmada-CLI-installtion-example/foreground.sh

killercoda-sample/karmada-CLI-installtion-example/index.json

killercoda-sample/karmada-CLI-installtion-example/intro.md

killercoda-sample/karmada-CLI-installtion-example/finish.md

killercoda-sample/karmada-CLI-installtion-example/intro.md

JadeFlute0127 · 2023-03-31T10:22:36Z

I think these problems have been solved~

jwcesign

Other looks good to me

karmada-CLI-installtion-and-deploy-example/foreground.sh

karmada-CLI-installtion-and-deploy-example/intro.md

jwcesign · 2023-04-03T07:04:59Z

Could you please share the scenario link for your experiment on Killercoda?

JadeFlute0127 · 2023-04-03T08:13:38Z

Could you please share the scenario link for your experiment on Killercoda?

https://killercoda.com/zhangdiandian/scenario/karmada-CLI-installtion-and-deploy-example

jwcesign · 2023-04-03T08:40:12Z

karmada-CLI-installtion-and-deploy-example/foreground.sh

+}
+
+function scpOperations() {
+  scp installKind.sh root@${member_cluster_ip}:~


how about the name copyConfigFilesToNode?

jwcesign · 2023-04-03T08:44:06Z

karmada-CLI-installtion-and-deploy-example/intro.md

+   ```
+3. join member clusters（kind-member1 and kind-member2）to karmada cluster
+
+   ```shell


I tried the example, but it requires manual input from you.
How about this one, just click,it will exec the command?
https://killercoda.com/kubevela/course/quick-start/kubevela-first-app

The MD file should specify that the subsequent operations can only be performed after the kind cluster is prepared.

jwcesign · 2023-04-03T08:56:49Z

karmada-CLI-installtion-and-deploy-example/foreground.sh

+KUBECONFIG_PATH=${KUBECONFIG_PATH:-"${HOME}/.kube"}
+
+function installKind() {
+cat << EOF > installKind.sh


Please leave a space of four. other places should be the same

JadeFlute0127 · 2023-04-03T10:29:11Z

fix done

RainbowMango · 2023-04-03T10:35:24Z

karmada-CLI-installtion-and-deploy-example/intro.md

@@ -0,0 +1,43 @@
+### Background：
+
+1. The kubeconfig files for the Karmada cluster, member1 cluster, and member2 cluster are located in the $HOME/.kube directory. These files are named config, config-member1, and config-member2 respectively.


We don't usually say Karmada cluster, if you mean the cluster where installing Karmada, I'd prefer to use host cluster.

Thank you for pointing out

karmada-CLI-installtion-and-deploy-example/intro.md

jwcesign · 2023-04-04T01:59:17Z

karmada-CLI-installtion-and-deploy-example/step1/verify.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+kubectl --kubeconfig=$HOME/.kube/config-member1 config get-contexts kind-member1


Add a line break, same as in other places.

this comment hasn't been addressed.

jwcesign · 2023-04-04T02:00:50Z

cc @RainbowMango, could you please review this? Overall, it looks good to me.

RainbowMango · 2023-04-04T02:15:39Z

Sure.
/assign

RainbowMango

Generally looks good to me. Just some small touches.

I see you name the steps by step1/spep2..., can we give them meaningful names?
Do we need verification for each steps?

RainbowMango · 2023-04-04T03:19:28Z

karmada-CLI-installtion-and-deploy-example/index.json

@@ -0,0 +1,38 @@
+{
+    "title": "install Karmada cluster through CLI",


We don't usually say Karmada cluster. How about

Suggested change

"title": "install Karmada cluster through CLI",

"title": "install Karmada through CLI",

For the first question，We define the name of each step in the index. json file。like this：

RainbowMango · 2023-04-04T03:20:09Z

karmada-CLI-installtion-and-deploy-example/index.json

@@ -0,0 +1,38 @@
+{
+    "title": "install Karmada cluster through CLI",
+    "description": "Installing a Karmada cluster with Kubernetes member through the Karmada CLI",


Suggested change

"description": "Installing a Karmada cluster with Kubernetes member through the Karmada CLI",

"description": "Installing Karmada on Kubernetes through the Karmada CLI",

RainbowMango · 2023-04-04T03:24:43Z

karmada-CLI-installtion-and-deploy-example/step1/verify.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+kubectl --kubeconfig=$HOME/.kube/config-member1 config get-contexts kind-member1


this comment hasn't been addressed.

RainbowMango · 2023-04-04T03:30:51Z

karmada-CLI-installtion-and-deploy-example/step4/verify.sh

Need a new line at end of file.

RainbowMango · 2023-04-04T03:31:44Z

karmada-CLI-installtion-and-deploy-example/step3/verify.sh

Need a new line at end of this file.

RainbowMango · 2023-04-04T03:32:05Z

karmada-CLI-installtion-and-deploy-example/step2/verify.sh

Please add a newline at end of this file.

RainbowMango · 2023-04-04T03:38:32Z

karmada-CLI-installtion-and-deploy-example/finish.md

@@ -0,0 +1 @@
+**The end**


It'd be great to have a summarize of this playground and make rooms for guiding people to other scenarios.

I will add the summary section.
Do you mean to switch to other scenes in Karmada? Other scenarios have not yet been implemented, and the website provides links to other scenarios in Killercoda.

For now, since we don't have any other scenarios yet, so a summary would be fine.
But in the future, we might need to add links to other scenarios for people to experience other features.

JadeFlute0127 · 2023-04-04T04:45:54Z

it looks fix done

jwcesign · 2023-04-04T06:16:36Z

2.Do we need verification for each steps?

I think that the following steps require the completion of the previous steps.

jwcesign · 2023-04-04T06:19:09Z

/lgtm
cc @RainbowMango for final checking

RainbowMango · 2023-04-04T06:39:55Z

karmada-CLI-installtion-and-deploy-example/finish.md

@@ -0,0 +1,3 @@
+**Summary**
+
+In this scenario, we learned how to initialize the Karmada control plane, join a cluster, and deploy workloads across multiple clusters.


and deploy workloads across multiple clusters

Seems we didn't have the step for deploying workloads, right?

We plan to work on it separately, and it should be completed in the next PR.

RainbowMango · 2023-04-04T06:50:41Z

karmada-CLI-installtion-and-deploy-example/intro.md

+
+Karmada aims to provide turnkey automation for multi-cluster application management in multi-cloud and hybrid cloud scenarios, with key features such as centralized multi-cloud management, high availability, failure recovery, and traffic scheduling.
+
+In this scenario, we will learn how to initialize the Karmada control plane, join clusters, and deploy workloads across multiple clusters.


ditto.
cc @jwcesign

karmada-bot · 2023-04-04T09:25:32Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JadeFlute0127 · 2023-04-04T13:16:46Z

remove about deploy workload info in intro.md and finish.md

jwcesign · 2023-04-06T02:14:21Z

karmada-CLI-installtion-and-deploy-example/intro.md

+
+Karmada aims to provide turnkey automation for multi-cluster application management in multi-cloud and hybrid cloud scenarios, with key features such as centralized multi-cloud management, high availability, failure recovery, and traffic scheduling.
+
+In this scenario, we will learn how to initialize the Karmada control plane, join clusters.


In this scenario, we will learn how to initialize the Karmada control plane and join clusters.

jwcesign · 2023-04-06T02:14:52Z

karmada-CLI-installtion-and-deploy-example/finish.md

@@ -0,0 +1,3 @@
+**Summary**
+
+In this scenario, we learned how to initialize the Karmada control plane, join a cluster.


In this scenario, we learned how to initialize the Karmada control plane and join a cluster.

yeah, thank you for your pointing out, that's a typo.
I think fix done.

Signed-off-by: zhangdiandian <1635468471@qq.com>

jwcesign · 2023-04-06T07:13:03Z

/lgtm

RainbowMango

/hold cancel

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2023

JadeFlute0127 force-pushed the main branch from f4383e1 to c384ab6 Compare March 30, 2023 13:11

jwcesign reviewed Mar 31, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch 7 times, most recently from 010fab3 to 412a7d0 Compare March 31, 2023 10:19

jwcesign reviewed Apr 3, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch from 412a7d0 to 3ca50a5 Compare April 3, 2023 08:12

JadeFlute0127 force-pushed the main branch from 3ca50a5 to 9e82a7c Compare April 3, 2023 08:25

karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2023

JadeFlute0127 force-pushed the main branch from 9e82a7c to 6d71f69 Compare April 3, 2023 08:27

karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2023

jwcesign reviewed Apr 3, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch 4 times, most recently from 03e5232 to 5d9e9f8 Compare April 3, 2023 10:03

RainbowMango reviewed Apr 3, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch 3 times, most recently from 8c7b554 to 9201620 Compare April 3, 2023 12:28

jwcesign reviewed Apr 4, 2023

View reviewed changes

karmada-bot assigned RainbowMango Apr 4, 2023

RainbowMango reviewed Apr 4, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch from 9201620 to 78b587f Compare April 4, 2023 04:41

karmada-bot assigned jwcesign Apr 4, 2023

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023

RainbowMango reviewed Apr 4, 2023

View reviewed changes

RainbowMango added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2023

JadeFlute0127 force-pushed the main branch from 78b587f to 71ed8b7 Compare April 4, 2023 13:15

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023

jwcesign reviewed Apr 6, 2023

View reviewed changes

update to install karmada through CLI

8732eb6

Signed-off-by: zhangdiandian <1635468471@qq.com>

JadeFlute0127 force-pushed the main branch from 71ed8b7 to 8732eb6 Compare April 6, 2023 04:52

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023

RainbowMango reviewed Apr 10, 2023

View reviewed changes

karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023

karmada-bot merged commit d0b6e3b into karmada-io:main Apr 10, 2023

JadeFlute0127 mentioned this pull request Jul 8, 2023

REQUEST: New membership for JadeFlute0127 karmada-io/community#41

Closed

8 tasks

		@@ -0,0 +1,43 @@
		### Background：

		1. The kubeconfig files for the Karmada cluster, member1 cluster, and member2 cluster are located in the $HOME/.kube directory. These files are named config, config-member1, and config-member2 respectively.

		@@ -0,0 +1,3 @@
		#!/bin/bash

		kubectl --kubeconfig=$HOME/.kube/config-member1 config get-contexts kind-member1

		@@ -0,0 +1,38 @@
		{
		"title": "install Karmada cluster through CLI",

	"title": "install Karmada cluster through CLI",
	"title": "install Karmada through CLI",

	"description": "Installing a Karmada cluster with Kubernetes member through the Karmada CLI",
	"description": "Installing Karmada on Kubernetes through the Karmada CLI",

		@@ -0,0 +1,3 @@
		Summary

		In this scenario, we learned how to initialize the Karmada control plane, join a cluster, and deploy workloads across multiple clusters.


		Karmada aims to provide turnkey automation for multi-cluster application management in multi-cloud and hybrid cloud scenarios, with key features such as centralized multi-cloud management, high availability, failure recovery, and traffic scheduling.

		In this scenario, we will learn how to initialize the Karmada control plane, join clusters, and deploy workloads across multiple clusters.

add killercoda example: install karmada through CLI #2

add killercoda example: install karmada through CLI #2

Conversation

JadeFlute0127 commented Mar 30, 2023 • edited Loading

karmada-bot commented Mar 30, 2023

jwcesign commented Mar 31, 2023

jwcesign left a comment

Choose a reason for hiding this comment

JadeFlute0127 commented Mar 31, 2023

jwcesign left a comment

Choose a reason for hiding this comment

jwcesign commented Apr 3, 2023

JadeFlute0127 commented Apr 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JadeFlute0127 commented Apr 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwcesign commented Apr 4, 2023

RainbowMango commented Apr 4, 2023

RainbowMango left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JadeFlute0127 commented Apr 4, 2023

jwcesign commented Apr 4, 2023 • edited Loading

jwcesign commented Apr 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karmada-bot commented Apr 4, 2023

JadeFlute0127 commented Apr 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwcesign commented Apr 6, 2023

RainbowMango left a comment

Choose a reason for hiding this comment

JadeFlute0127 commented Mar 30, 2023 •

edited

Loading

jwcesign commented Apr 4, 2023 •

edited

Loading