add two examples for karmada deploy workloads #3

JadeFlute0127 · 2023-04-10T09:55:23Z

Signed-off-by: [JadeFlute0127] [1635468471@qq.com]

What this PR does / why we need it:
add two examples for karmada deploy workloads

Which issue(s) this PR fixes:
Part of #1

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

jwcesign

Could you please provide the link to the example here?

jwcesign · 2023-04-10T11:24:59Z

karmada-CLI-deploy-example1/finish.md

@@ -0,0 +1,3 @@
+**Summary**
+
+In this scenario, we will learn how to deploy workloads across multiple clusters. More specifically, use propagationPolicy and staticWeight to divide nginx deployment.


How about the following description:

In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy with StaticWeight configuration to divide the nginx deployment.

yours description better

jwcesign · 2023-04-10T11:26:20Z

karmada-CLI-deploy-example1/foreground.sh

@@ -0,0 +1,156 @@
+#!/usr/bin/env bash
+
+set -o errexit


I prefer to give the directory name karmada-division-deploy-example.

jwcesign · 2023-04-10T11:27:51Z

karmada-CLI-deploy-example2/finish.md

@@ -0,0 +1,3 @@
+**Summary**
+
+In this scenario, we learned how to deploy workloads across multiple clusters. More specifically, use the propagationPolicy and duplicate modes to deploy nginx.


same with before

jwcesign · 2023-04-10T11:29:28Z

karmada-CLI-deploy-example2/foreground.sh

@@ -0,0 +1,147 @@
+#!/usr/bin/env bash
+
+set -o errexit


I prefer to give the directory name karmada-duplicate-deploy-example

jwcesign · 2023-04-11T01:30:57Z

karmada-division-deploy-example/index.json

+        },
+        {
+          "title": "Create propagationPolicy and deploy pods",
+          "text": "step3/text.md",


Create propagationPolicy and deploy deployment

jwcesign · 2023-04-11T01:38:37Z

karmada-division-deploy-example/step1/text.md

+   ```
+2. Check whether the member cluster has been joined
+
+   RUN `kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get cluster`{{exec}}


How about adding a note here (because it may make users confused why checking failed):

PS: Initializing the testing environment may take a few minutes.

jwcesign · 2023-04-11T01:40:47Z

karmada-division-deploy-example/step2/text.md

+
+create deployment named nginx
+
+   RUN `kubectl --kubeconfig /etc/karmada/karmada-apiserver.config create -f ~/nginx/nginxDeployment.yaml`{{exec}}


apply is a better choice, it could be applied multiple times without error:
kubectl --kubeconfig /etc/karmada/karmada-apiserver.config apply -f ~/nginx/nginxDeployment.yaml

jwcesign · 2023-04-11T01:44:50Z

karmada-division-deploy-example/step2/verify.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get deployment


Verification can be passed even if the deployment has not been created yet.

kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get deployment nginx

jwcesign

The other looks good to me.

jwcesign · 2023-04-11T06:46:34Z

karmada-division-deploy-example/finish.md

@@ -0,0 +1,3 @@
+**Summary**
+
+In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy with StaticWeight configuration to divide the nginx deployment.


In this scenario, we learned how xxxx

jwcesign · 2023-04-11T06:47:01Z

karmada-duplication-deploy-example/finish.md

@@ -0,0 +1,3 @@
+**Summary**
+
+In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy to duplicate the nginx deployment.


same with before

jwcesign · 2023-04-11T06:49:20Z

cc @RainbowMango for checking
https://killercoda.com/zhangdiandian/

jwcesign · 2023-04-11T07:22:54Z

/lgtm

RainbowMango

/assign
I will add it to my queue and will try to review it by the end of this week.

RainbowMango · 2023-04-13T01:50:04Z

karmada-duplication-deploy-example/index.json

@@ -0,0 +1,36 @@
+{
+    "title": "deploy workload through karmada duplicated type",


The title is based on technology, perhaps it would be better to use a description that reflects value.

Such as

HA workload deployment

RainbowMango · 2023-04-13T01:53:29Z

karmada-division-deploy-example/index.json

@@ -0,0 +1,36 @@
+{
+    "title": "deploy workload through karmada divided type",


Same as the other sceanrio. People might not interested in the propagation mode is divided or duplicated.

The title field will be in the Killercoda sceanrio name. If the previous one is called HA workload deployment, then this one should be different from the previous one's name

Signed-off-by: zhangdiandian <1635468471@qq.com>

JadeFlute0127 · 2023-04-14T02:38:06Z

I think an effect similar to the following can better distinguish between two scenarios

jwcesign · 2023-04-17T03:32:20Z

I think an effect similar to the following can better distinguish between two scenarios

I think this description is ok.
cc @RainbowMango for checking

RainbowMango

/lgtm
/approve

karmada-bot · 2023-04-17T07:48:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2023

jwcesign reviewed Apr 10, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch from 201d067 to fe9b665 Compare April 10, 2023 11:51

jwcesign reviewed Apr 11, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch from fe9b665 to 5f98681 Compare April 11, 2023 04:37

jwcesign reviewed Apr 11, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch 3 times, most recently from 7a51b43 to 352d797 Compare April 11, 2023 07:17

karmada-bot assigned jwcesign Apr 11, 2023

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023

RainbowMango reviewed Apr 11, 2023

View reviewed changes

karmada-bot assigned RainbowMango Apr 11, 2023

RainbowMango reviewed Apr 13, 2023

View reviewed changes

JadeFlute0127 force-pushed the main branch from 352d797 to 24fd1e9 Compare April 13, 2023 15:57

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023

JadeFlute0127 force-pushed the main branch 2 times, most recently from 56543e5 to 3b4e320 Compare April 13, 2023 16:12

add two examples for karmada deploy workloads

a3721fb

Signed-off-by: zhangdiandian <1635468471@qq.com>

JadeFlute0127 force-pushed the main branch from 3b4e320 to a3721fb Compare April 14, 2023 02:34

RainbowMango approved these changes Apr 17, 2023

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023

karmada-bot merged commit bad15aa into karmada-io:main Apr 17, 2023
1 check passed

JadeFlute0127 mentioned this pull request Jul 8, 2023

REQUEST: New membership for JadeFlute0127 karmada-io/community#41

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add two examples for karmada deploy workloads #3

add two examples for karmada deploy workloads #3

JadeFlute0127 commented Apr 10, 2023

jwcesign left a comment

jwcesign Apr 10, 2023

JadeFlute0127 Apr 10, 2023

jwcesign Apr 10, 2023

jwcesign Apr 10, 2023

JadeFlute0127 Apr 10, 2023

jwcesign Apr 10, 2023

jwcesign Apr 11, 2023

jwcesign Apr 11, 2023 •

edited

JadeFlute0127 Apr 11, 2023

jwcesign Apr 11, 2023

JadeFlute0127 Apr 11, 2023

jwcesign Apr 11, 2023

JadeFlute0127 Apr 11, 2023

jwcesign left a comment

jwcesign Apr 11, 2023

jwcesign Apr 11, 2023

JadeFlute0127 Apr 11, 2023

jwcesign commented Apr 11, 2023

jwcesign commented Apr 11, 2023

RainbowMango left a comment

RainbowMango Apr 13, 2023

RainbowMango Apr 13, 2023

JadeFlute0127 Apr 13, 2023 •

edited

JadeFlute0127 commented Apr 14, 2023

jwcesign commented Apr 17, 2023

RainbowMango left a comment

karmada-bot commented Apr 17, 2023

		@@ -0,0 +1,3 @@
		Summary

		In this scenario, we will learn how to deploy workloads across multiple clusters. More specifically, use propagationPolicy and staticWeight to divide nginx deployment.

		@@ -0,0 +1,3 @@
		Summary

		In this scenario, we learned how to deploy workloads across multiple clusters. More specifically, use the propagationPolicy and duplicate modes to deploy nginx.


		create deployment named nginx

		RUN `kubectl --kubeconfig /etc/karmada/karmada-apiserver.config create -f ~/nginx/nginxDeployment.yaml`{{exec}}

		@@ -0,0 +1,3 @@
		#!/bin/bash

		kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get deployment

		@@ -0,0 +1,3 @@
		Summary

		In this scenario, we'll learn how to deploy workloads across multiple clusters using PropagationPolicy with StaticWeight configuration to divide the nginx deployment.

		@@ -0,0 +1,36 @@
		{
		"title": "deploy workload through karmada duplicated type",

add two examples for karmada deploy workloads #3

add two examples for karmada deploy workloads #3

Conversation

JadeFlute0127 commented Apr 10, 2023

jwcesign left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwcesign Apr 11, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwcesign left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwcesign commented Apr 11, 2023

jwcesign commented Apr 11, 2023

RainbowMango left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JadeFlute0127 Apr 13, 2023 • edited

Choose a reason for hiding this comment

JadeFlute0127 commented Apr 14, 2023

jwcesign commented Apr 17, 2023

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Apr 17, 2023

jwcesign Apr 11, 2023 •

edited

JadeFlute0127 Apr 13, 2023 •

edited