Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize anp document #208

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Optimize anp document #208

merged 1 commit into from
Oct 24, 2022

Conversation

lonelyCZ
Copy link
Member

Signed-off-by: lonelyCZ 531187475@qq.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 14, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2022
@RainbowMango
Copy link
Member

Does this mean to fix karmada-io/karmada#2628?

@lonelyCZ
Copy link
Member Author

Does this mean to fix karmada-io/karmada#2628?

No, only to fix spell error.

And karmada-host-control-plane is not easy to understand, because we usually use karmada-control-plane and karmada-host, but I neet to investigate why using this in the document, whether it is associated to Kind cluster name.

@RainbowMango
Copy link
Member

OK. Please assign it to @XiShanYongYe-Chang once it's ready.

@lonelyCZ lonelyCZ changed the title [WIP]Optimize anp document Optimize anp document Oct 17, 2022
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2022
@lonelyCZ
Copy link
Member Author

PTAL~

/assign @XiShanYongYe-Chang

Arhell
Arhell reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to reply so late. I took a vacation some time ago.

docs/userguide/clustermanager/working-with-anp.md Outdated Show resolved Hide resolved
docs/userguide/clustermanager/working-with-anp.md Outdated Show resolved Hide resolved
docs/userguide/clustermanager/working-with-anp.md Outdated Show resolved Hide resolved
@lonelyCZ
Optimize anp document
1a26370 
Signed-off-by: lonelyCZ <chengzhe@zju.edu.cn>
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@karmada-bot karmada-bot merged commit 9e5aa40 into karmada-io:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@rgrupesh rgrupesh Awaiting requested review from rgrupesh

Assignees

@Arhell Arhell

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lonelyCZ @RainbowMango @karmada-bot @Arhell @XiShanYongYe-Chang