Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix company logo #329

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix company logo #329

merged 1 commit into from
Mar 6, 2023

Conversation

whitewindmills
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
fix company logo
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Signed-off-by: whitewindmills <jayfantasyhjh@gmail.com>
@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
Copy link
Member

@rgrupesh rgrupesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boundary box is still not identical in dark mode. Please fix that.
Screenshot from 2023-03-06 09-31-01

@RainbowMango
Copy link
Member

/lgtm
/approve

I think this PR just replaced the png files, the layout issue will be fixed by #327.

Thanks @whitewindmills

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@karmada-bot karmada-bot merged commit 2cc0930 into karmada-io:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants