Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the document to explain the usage of build-in functions … #360

Merged

Conversation

yike21
Copy link
Member

@yike21 yike21 commented May 27, 2023

…of luavm to users, and add a ResourceInterpreterCustomization writing sample.

What type of PR is this?
/kind documentation

What this PR does / why we need it:
It's helpful for users to explain the usage of build-in functions of luavm. And a ResourceInterpreterCustomization writing sample is also helpful for users to customize their own resource.

Which issue(s) this PR fixes:
Fixes #343

Special notes for your reviewer:
@Poor12 @XiShanYongYe-Chang

…of luavm to users, and add a ResourceInterpreterCustomization writing sample

Signed-off-by: yike21 <yike21@qq.com>
@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 27, 2023
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 27, 2023
@Poor12
Copy link
Member

Poor12 commented May 31, 2023

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@karmada-bot karmada-bot merged commit 507e242 into karmada-io:main May 31, 2023
7 checks passed
@yike21 yike21 deleted the update-ResourceInterpreterCustomization branch May 31, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a document to explain the usage of build-in functions of luavm to users
4 participants