Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh]translate docs:migration-from-kubefed.md #405

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[zh]translate docs:migration-from-kubefed.md #405

merged 1 commit into from
Jul 12, 2023

Conversation

justedennnnn
Copy link
Contributor

What type of PR is this?

/kind documentation

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 3, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2023
windsonsea
windsonsea reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some terms like override and propagation will be clear if you can look up through the documents. Comments here are only for reference. Thanks.

.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
windsonsea
windsonsea suggested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

汗，这大部分都没改呀，怎么就点了 Resolve conversation 了？

@windsonsea
Copy link
Member

/hold until all comments are really resolved

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
@RainbowMango
Copy link
Member

@justedennnnn Can you help to resolve the conflicts, the typo in docs/administrator/migration/migration-from-kubefed.md has been resolved in #416.

Poor12
Poor12 reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@Poor12 Poor12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check again whether the previous review comments have been modified.

.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
@justedennnnn
Copy link
Contributor Author

/hold until all comments are really resolved

sorry，forget to save changes

@windsonsea
Copy link
Member

/unhold

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
windsonsea
windsonsea reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your revising.

.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
.../zh/docusaurus-plugin-content-docs/current/administrator/migration/migration-from-kubefed.md Outdated Show resolved Hide resolved
@justedennnnn justedennnnn force-pushed the zh-docs branch 3 times, most recently from 53dd2dd to 8ad2b4f Compare July 11, 2023 05:54
@justedennnnn
[zh]translate docs:migration-from-kubefed.md
0161078 
Signed-off-by: justedennnnn <justedennnn@163.com>
@windsonsea
Copy link
Member

Thanks.
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@samzong
Copy link
Member

samzong commented Jul 12, 2023

I think it's all great.

/lgtm
/approve

Thanks for your contribution.

@justedennnnn justedennnnn mentioned this pull request Jul 12, 2023
Closed
8 tasks
@justedennnnn
Copy link
Contributor Author

I think it's all great.

/lgtm /approve

Thanks for your contribution.

Thanks for your review.

@justedennnnn
Copy link
Contributor Author

@justedennnnn Can you help to resolve the conflicts, the typo in docs/administrator/migration/migration-from-kubefed.md has been resolved in #416.

Done

RainbowMango
RainbowMango approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, SAMZONG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@karmada-bot karmada-bot merged commit 32a777c into karmada-io:main Jul 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samzong samzong samzong left review comments

@Poor12 Poor12 Poor12 left review comments

@windsonsea windsonsea windsonsea requested changes

@RainbowMango RainbowMango RainbowMango approved these changes

Assignees

@samzong samzong

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@justedennnnn @windsonsea @RainbowMango @samzong @karmada-bot @Poor12