Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: migrate existing resource from a cluster to karmada #431

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Best practice of migrate existing resource from a cluster to karmada

Which issue(s) this PR fixes:

karmada-io/karmada#3824

Special notes for your reviewer:
@RainbowMango

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 27, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2023
@RainbowMango
Copy link
Member

My opinion:

  1. This doc should focus on teaching people how to migrate legacy resource from a cluster to Karmada instead of a demo;
  2. The content now seems like a tutorial which should be organized into docs/tutorials.

@chaosi-zju
Copy link
Member Author

chaosi-zju commented Aug 14, 2023

/cc RainbowMango

I think it is ready to review again~ migrate-existing-resource

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

kindly ping @RainbowMango quick click

docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
docs/tutorials/resource-migration.md Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

kindly ping @RainbowMango

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@karmada-bot karmada-bot merged commit 21e1a6c into karmada-io:main Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants