Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Fix and improve determine cluster failures #445

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

wilsonwu
Copy link
Contributor

@wilsonwu wilsonwu commented Aug 7, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Improve format and fix typo of determine cluster failures

i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/determine-cluster-failures.md

Which issue(s) this PR fixes:
No

Special notes for your reviewer:

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 7, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2023
@windsonsea
Copy link
Member

/lgtm
IMO whether we should consider to put more energy into new translations like tutorials, user guide, and more.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@samzong
Copy link
Member

samzong commented Aug 22, 2023

/approve That's great. Thank you for all your work.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samzong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@karmada-bot karmada-bot merged commit 853adb0 into karmada-io:main Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants