Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] optimize text and layout of core-concept.md #85

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Jun 16, 2022

The original webpage is https://karmada.io/docs/getting-started/core-concept

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Have a try to make it beautiful and official.

Which issue(s) this PR fixes:
Grammar and layout optimization

Special notes for your reviewer:
Not sure if all my changes are correct or not. Need your confirmation, thanks.
@rgrupesh @Arhell

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 16, 2022
@karmada-bot
Copy link
Collaborator

Welcome @windsonsea! It looks like this is your first PR to karmada-io/website 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2022
@RainbowMango
Copy link
Member

Thanks @windsonsea
Please @rgrupesh @Arhell help.

Have a try to make it beautiful and official. Not sure if all my changes are correct or not. Need your confirmation, thanks.

The original webpage is https://karmada.io/docs/getting-started/core-concept

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@RainbowMango
Copy link
Member

@windsonsea Thanks.

@karmada-bot karmada-bot merged commit fb79c68 into karmada-io:main Jun 17, 2022
@windsonsea windsonsea deleted the patch-1 branch February 2, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants