Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering on seq range, e.g. seq=5,, seq=,10, or seq=5,10 #36

Closed
karmakaze opened this issue Aug 20, 2018 · 1 comment
Closed
Assignees

Comments

@karmakaze
Copy link
Owner

karmakaze commented Aug 20, 2018

Front-end quickvue can show duplicate rows when loading prev or next.
This can happen because we get rows <= earliest published we already have (or rows >= latest published we already have). If there are several rows with the same timestamp, the front-end only de-duplicates the adjacent row (e.g. latest fetched with earliest already had).

We can fix this by using seq for loading prev and next, then the relations will be non-overlapping (e.g. rows where seq < earliest seq we already have).

@karmakaze karmakaze self-assigned this Aug 20, 2018
@karmakaze karmakaze changed the title Front-end quickvue can show duplicate rows when loading prev or next Allow filtering on seq range, e.g. seq=5,, seq=,10, or seq=5,10 Aug 21, 2018
@karmakaze
Copy link
Owner Author

For consistency with the behaviour of published=, opted to make the ranges inclusive. This means if the client doesn't want the row matching the range limit, it must be incremented or decremented accordingly. Otherwise it could retrieve the row and merely omit it as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant