This repository has been archived by the owner on Jun 30, 2018. It is now read-only.
Add support for text queries to the DSL #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Nathan, could you add a simple integration test as well? Also, could you post here the troubles with the test suite? It should really be working with no problems... |
|
The tests, including Nathan's addition, all pass after running: |
|
@woodhull: Could you add some simple integration test, please? If you have troubles running the tests, bug me here or on IRC! |
|
Karmi, Just added a quick integration test! -Nathan |
karmi
pushed a commit
that referenced
this pull request
Feb 14, 2012
Example:
Tire.search('articles-test') do
query { text :title, '+1' }
end
See <http://www.elasticsearch.org/guide/reference/query-dsl/text-query.html>
|
Nathan, I'm terribly sorry it took me song long to process the patch. It's now included with some cleanups in a7a62d6. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a quick unit test for this as well, but I was unable to execute it because I had trouble getting the test suite working.
Small addition to support:
http://www.elasticsearch.org/guide/reference/query-dsl/text-query.html
Thanks,
Nathan