Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding torch/nn to dependencies #92

Merged
merged 1 commit into from
Aug 27, 2015
Merged

adding torch/nn to dependencies #92

merged 1 commit into from
Aug 27, 2015

Conversation

ajkl
Copy link
Contributor

@ajkl ajkl commented Aug 26, 2015

No description provided.

@karpathy
Copy link
Owner

Oops, doesn't nn come with Torch by default? I can't remember now.

@ajkl
Copy link
Contributor Author

ajkl commented Aug 27, 2015

I am not sure either. Probably a version mismatch as Soumith mentioned. Dont have much experience with torch, but luarocks install nn clearly solves #76 for me. Maybe this can be added in Notes section and not in the dependencies section of the README ? Let me know I can modify the PR.

@karpathy
Copy link
Owner

I think you had nn but somehow an older version of it, and when you installed it was updated? Hmmmm

@ajkl
Copy link
Contributor Author

ajkl commented Aug 27, 2015

Correct. And I had just installed torch for the first time before doing all this. So I was assuming nn will already be on latest version. I guess I was wrong.

karpathy added a commit that referenced this pull request Aug 27, 2015
adding torch/nn to dependencies
@karpathy karpathy merged commit 065c5ff into karpathy:master Aug 27, 2015
@karpathy
Copy link
Owner

alright, can't hurt :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants