-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI github actions workflow to verify builds on pull_request #86
Conversation
CI pipeline looks good : https://github.com/tairov/llama2.c/actions/runs/5662603534 |
Actually I like this, but few things:
|
(By consistent I mean no underscores in target names, e.g. just make it clangomp or something?) |
I agree regarding naming consistency -- Fixed. |
@karpathy added windows platform build job (pipeline : https://github.com/tairov/llama2.c/actions/runs/5663670418 ) Erorrs with Windows builds ignored at the moment:
Seems that compilations on Windows are not working via CL.exe at least , #91 Also removed irrelevant |
Adapted |
2b8ca1d
to
329cfd3
Compare
Fixed builds for windows . Now CI workflow uses |
a79d92a
to
956be53
Compare
@tairov please let me know when you think this could be good to merge. CI would be very nice! |
Code rebased to catch up with upstream/master @karpathy it's ready to be merged. On my fork I'm using this to check builds for multiple platforms instantly - linux, macos, window (x86, 64, arm) very convenient. Here is example how action execution will look like once a PR created in the repo that propose changes in any following files |
Exciting, thank you! |
Add CI github actions workflow to verify builds on pull_request
This CI workflow provides a system that ensures every change made to the master branch, specifically to
Makefiles
,*.h
, or C source files, doesn't break the build process, improving the reliability and stability of the project.It'd be nice to have basic build validation in order to avoid issues on different platforms like this one : #80
Builds validation platforms:
Linux : ✅
MacOS : ✅
Windows : ✅