Example for the dtype change for gelu kernels #250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the type of data that is being read from memory, in a single memory operation it is possible to read up to 128 bits of data. For memory constrained kernels it is beneficial to wrap all of the sequential reads in the format shown in this PR so that the effects of the latency of the memory reads is reduced.
For future kernel changes that also require coalesced memory reads it is now possible to use this struct that has methods to easily access the underlying data using the [] operation.
This changes the iter speed for me on my A100 from:
total average iteration time: 45.785989 ms
to around:
total average iteration time: 44.766054 ms
Co-authored-by: @ngc92 - Came up with the memory struct idea