Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first attempt at moving cudnn out of the main file for faster compiles #346

Merged
merged 4 commits into from
May 5, 2024

Conversation

ngc92
Copy link
Contributor

@ngc92 ngc92 commented May 3, 2024

I think this breaks nonCudnn build, and possibly also windows. I have little knowledge about makefiles, though, so if someone knows how to do things nicely, that would be great :)

@rosslwheeler
Copy link
Contributor

rosslwheeler commented May 3, 2024

@ngc92 -Windows is running FAST. And I'm not talking about compile time. Fastest I've ever seen it. Ubuntu 22.04/WSL2 is about 10 percent slower than Windows (?) but still faster than before. Will do some cleanup next...

@ngc92 ngc92 marked this pull request as ready for review May 5, 2024 00:00
@karpathy karpathy merged commit f2224f2 into karpathy:master May 5, 2024
6 checks passed
@rosslwheeler
Copy link
Contributor

I have some Makefile changes but will submit those in a separate PR.

@ngc92 ngc92 deleted the separate-compilation branch May 19, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants