Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Dataloader test and ptx/sass file generator #629

Merged
merged 5 commits into from
Jun 29, 2024
Merged

CI Dataloader test and ptx/sass file generator #629

merged 5 commits into from
Jun 29, 2024

Conversation

rosslwheeler
Copy link
Contributor

  • New CI tests file - added dataloader test and ptx/sass file generator to it.
  • Cuda Makefile - added capability build from main Makefile. Added support for ptx and sass output files.
  • layernorm_forward.cu - remove #define (was already in header file)
  • dev/test/Makefile - new file (based on main Makefile) for running tests
  • dataloader.h - added casts to remove compiler warnings
  • rand.h - removed unused parameter. Added casts to remove compiler warnings.
  • train_gpt2.c - rename unsigned long long to uint64_t.

Pre-verified with CI.

@rosslwheeler
Dataloader test and ptx/sass file generator
5b95bff 
Setup new test infrastructure
ngc92
ngc92 reviewed Jun 22, 2024
View reviewed changes
dev/test/Makefile Outdated Show resolved Hide resolved
ngc92
ngc92 reviewed Jun 22, 2024
View reviewed changes
dev/test/Makefile Outdated Show resolved Hide resolved
@karpathy karpathy merged commit 2daaf6a into karpathy:master Jun 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngc92 ngc92 ngc92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rosslwheeler @ngc92 @karpathy