rolling checkpoints #636
Merged
rolling checkpoints #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checkpoints get deleted with a rolling window. This is an optimization that will allow us to save state more often, but preserve disk space overall. And if we ever see loss spikes and such, it is easier to reset the state to an earlier checkpoint that is more recent
ngc92
reviewed
Jun 25, 2024
| @@ -1284,7 +1284,7 @@ void load_state(int* step, GPT2* model, DataLoader* loader, const char* filename | |||
|
|
|||
| // ---------------------------------------------------------------------------- | |||
| // CLI, poor man's argparse | |||
| // unclaimed flags lol: p | |||
| // (all single letters have been claimed now) | |||
ngc92
reviewed
Jun 25, 2024
train_gpt2.cu
Outdated
| if (checkpoints_keep > 0 && step_delete > 0 && | ||
| (major_checkpoint_every == 0 || step_delete % major_checkpoint_every != 0) | ||
| ) { | ||
| printf0("deleting minor checkpoint %d\n", step_delete); |
There was a problem hiding this comment.
make a dedicated delete_checkpoint function?
ngc92
reviewed
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkpoints are either MINOR or MAJOR and minor checkpoints get deleted with a rolling window. This is an optimization that will allow us to save state more often, but preserve disk space overall. And if we ever see loss spikes and such, it is easier to reset the state to an earlier checkpoint that is more recent
Introduces two new flags:
Example usage:
This will write checkpoint every 20 steps, only keeps up to 3 minor checkpoints in the directory at any time, except every 100th checkpoint is considered a MAJOR checkpoint, and will not be deleted.