Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently based on #635 , because there we ended up needing to reduce losses in bf16.
So this PR first does some malloc-and-point generalization for allowing multiple dtypes, and then changes layernorm statistics and losses to fp32.
With layernorm stats in fp32, we can reliably avoid their recomputation even if we recompute the layer itself, and these tensors are still tiny, so it doesn't cost us much.