Implement modular encoder/decoder class #364
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a set of encoder/decoder classes that provide a consistent interface for encoding and decoding text using different schemes like character or BPE encoding.
The main changes:
This allows cleanly switching between different encoding implementations by just changing the imported EncoderDecoder class. New schemes can easily be added by implementing a new subclass.
Some benefits:
Let me know if any changes are needed! Please take a look at the EncoderDecoder class design and see if it meets the goals of modular and extensible encodings.
Usage example: