Improve robustness of DataLoaderRaw for non-image files #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karpathy
added a commit
that referenced
this pull request
Nov 25, 2015
Improve robustness of DataLoaderRaw for non-image files
|
Thank you very much @fmassa for the PR, looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some systems, the hidden system files could cause problems while listing the files in a folder, as in #11.
We could consider that this is a problem with
imageregex https://github.com/torch/image/blob/master/init.lua#L341 , that doesn't handle properly some cases (like.DS_Store).This is a simple attempt to circumvent this problem without changing
image.