Expose base storage classes #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ewilliamson-patreon! |
karpetrosyan
approved these changes
Apr 4, 2024
|
Can we also have a changelog? |
ewilliamson-patreon
force-pushed
the
expose-base-storage-classes
branch
from
a057e78
to
70975b6
Compare
|
Added a changelog entry, modeled it after another expose changelog entry |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr exposes the storage base classes on the hishel module. Right now to import these you need to use the private dunder paths i.e.
hishel._async._storages.AsyncBaseStorageAfter this pr, these will be available at
hishel.AsyncBaseStorageI can see the value in exposing the base class for 2 reasons:
Libraries using hishel may want to be able to pass a storage class in a typed way through their library
Users of hishel may want to make their own custom storage not based on any of the existing classes, so could now extend the base