Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #71

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Add support for Python 3.12 #71

merged 5 commits into from
Sep 19, 2023

Conversation

karpetrosyan
Copy link
Owner

@karpetrosyan karpetrosyan commented Sep 19, 2023

Following encode/httpcore#807 and encode/httpx#2854, we should also add support for Python 3.12.

Thanks to @hugovk

TODO

  • Add changelog

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #71 (020f769) into master (befab19) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1544      1544           
=========================================
  Hits          1544      1544           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Note there are some new deprecation warnings, they don't need fixing immediately but don't leave it too late:

/home/runner/work/hishel/hishel/tests/_async/test_storages.py:11: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).

https://github.com/karosis88/hishel/actions/runs/6236903274/job/16929269582?pr=71#step:7:56

@karpetrosyan
Copy link
Owner Author

Looks good!

Note there are some new deprecation warnings, they don't need fixing immediately but don't leave it too late:

/home/runner/work/hishel/hishel/tests/_async/test_storages.py:11: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).

https://github.com/karosis88/hishel/actions/runs/6236903274/job/16929269582?pr=71#step:7:56

Thank you so much for the review!

@karpetrosyan karpetrosyan merged commit 88e93c5 into master Sep 19, 2023
7 checks passed
@karpetrosyan karpetrosyan deleted the add-python-312-support branch October 3, 2023 08:57
@karpetrosyan karpetrosyan mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants