Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsDevice function #28

Merged
merged 1 commit into from May 6, 2019
Merged

IsDevice function #28

merged 1 commit into from May 6, 2019

Conversation

pjdufour
Copy link
Contributor

@pjdufour pjdufour commented May 4, 2019

This PR adds a IsDevice() function that increases ease of use of this package when walking a directory of devices.

@pjdufour pjdufour force-pushed the devices branch 2 times, most recently from 8c89904 to bd57465 Compare May 4, 2019 20:21
karrick
karrick requested changes May 6, 2019
View reviewed changes
Copy link
Owner

@karrick karrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with adding this feature, but please remove the latter half of the comment that does not necessarily apply to this method.

dirent.go Outdated Show resolved Hide resolved
@karrick karrick merged commit 964ad4f into karrick:master May 6, 2019
@karrick
Copy link
Owner

karrick commented May 6, 2019

Awesome. Thank you.

@pjdufour pjdufour deleted the devices branch May 6, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrick karrick karrick requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pjdufour @karrick