New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add place types #1159
Add place types #1159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
+ Coverage 93.56% 93.62% +0.06%
==========================================
Files 484 493 +9
Lines 18466 18709 +243
Branches 1267 1279 +12
==========================================
+ Hits 17278 17517 +239
- Misses 956 957 +1
- Partials 232 235 +3
Continue to review full report at Codecov.
|
2b9b296
to
7f16880
Compare
7f16880
to
074ed0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! I went over it and wrote some thoughts down, maybe it's helpful to you.
Yup, very helpful, thanks ⭐ Let's hope the tests are good enough to properly test the code changes from the review... |
This is basically the same as #1122 but without changing anything about the place statuses. The aim is to reduce the complexity, so I can get something mergable sooner, and deal with any changes to the handling of statuses after that.
It adds a new model "place types" so we can have different types of place with their own icons (and in the future, perhaps behaviour).
There are more detailed thoughts about it on the community forum post --> https://community.foodsaving.world/t/custom-place-types/705/4
TODO