Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from all conversations when leaving group #1264

Merged
merged 5 commits into from Jul 26, 2023

Conversation

nicksellen
Copy link
Member

Fixes karrot-dev/karrot-frontend#2571

There are multiple types of chat where users are not always removed from the chat when leaving the group. Activity chats is one case, which was an issue for past activity chats.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1264 (1997dfd) into master (cc200e1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   92.87%   92.92%   +0.04%     
==========================================
  Files         537      539       +2     
  Lines       21431    21545     +114     
  Branches     1547     1549       +2     
==========================================
+ Hits        19904    20020     +116     
+ Misses       1208     1207       -1     
+ Partials      319      318       -1     
Files Changed Coverage Δ
karrot/activities/receivers.py 98.64% <100.00%> (ø)
...rations/0043__cleanup_conversation_participants.py 100.00% <100.00%> (ø)
karrot/conversations/models.py 97.67% <100.00%> (+0.01%) ⬆️
karrot/conversations/tests/test_api.py 100.00% <100.00%> (ø)
karrot/conversations/tests/test_data_migrations.py 100.00% <100.00%> (ø)
karrot/groups/receivers.py 89.58% <100.00%> (+0.92%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@tiltec tiltec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! I guess we can make a database backup right before deploying to production, just to be safe :) Also, messages are not lost when a participant is deleted, so it's mostly reversible.

karrot/places/receivers.py Outdated Show resolved Hide resolved
@nicksellen nicksellen changed the title Remove from activity chat when leaving group Remove from all conversations when leaving group Jul 25, 2023
@nicksellen nicksellen marked this pull request as ready for review July 26, 2023 11:44
@nicksellen nicksellen merged commit e19aa8c into master Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants