Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated feedback #1267

Merged
merged 3 commits into from Aug 30, 2023
Merged

Consolidated feedback #1267

merged 3 commits into from Aug 30, 2023

Conversation

nicksellen
Copy link
Member

For karrot-dev/karrot-frontend#2668 feedback is now displayed per-activity, so it makes sense to use the activity endpoint, but include the feedback in it.

Also adds:

  • can order by date or reverse date
  • can filter activities by whether they have feedback (yes, no, unspecified)
  • removed the default massive default pagination values for activities, as that was before client pagination for activities was a thing
  • add PYTHONUNBUFFERED=1 for honcho dev setup so print statements log immediately

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1267 (a59d8ba) into master (de4be4f) will increase coverage by 0.00%.
The diff coverage is 96.85%.

@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   92.69%   92.70%           
=======================================
  Files         541      541           
  Lines       21642    21693   +51     
  Branches     1559     1565    +6     
=======================================
+ Hits        20061    20110   +49     
- Misses       1261     1263    +2     
  Partials      320      320           
Files Changed Coverage Δ
...arrot/activities/tests/test_activity_series_api.py 99.09% <ø> (ø)
karrot/bootstrap/api.py 89.15% <ø> (ø)
karrot/bootstrap/tests/test_api.py 100.00% <ø> (ø)
karrot/activities/filters.py 82.35% <42.85%> (-4.54%) ⬇️
karrot/activities/api.py 87.50% <100.00%> (+0.12%) ⬆️
karrot/activities/models.py 92.98% <100.00%> (+0.75%) ⬆️
karrot/activities/serializers.py 85.27% <100.00%> (+0.26%) ⬆️
karrot/activities/tests/test_activities_api.py 99.60% <100.00%> (+0.01%) ⬆️
karrot/bootstrap/serializers.py 100.00% <100.00%> (ø)
karrot/utils/misc.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nicksellen nicksellen merged commit 752968b into master Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant