Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from FCM to WebPush #1271

Merged
merged 10 commits into from Oct 11, 2023
Merged

Switch from FCM to WebPush #1271

merged 10 commits into from Oct 11, 2023

Conversation

nicksellen
Copy link
Member

@nicksellen nicksellen commented Oct 10, 2023

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1271 (7b119c4) into master (200288b) will decrease coverage by 0.02%.
The diff coverage is 94.81%.

❗ Current head 7b119c4 differs from pull request most recent head 789b515. Consider uploading reports for the commit 789b515 to get more accurate results

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   92.67%   92.66%   -0.02%     
==========================================
  Files         543      546       +3     
  Lines       21754    21692      -62     
  Branches     1572     1551      -21     
==========================================
- Hits        20161    20100      -61     
- Misses       1272     1273       +1     
+ Partials      321      319       -2     
Files Coverage Δ
karrot/activities/tasks.py 87.69% <100.00%> (ø)
karrot/activities/tests/test_tasks.py 96.25% <100.00%> (ø)
karrot/bootstrap/api.py 89.15% <ø> (ø)
karrot/bootstrap/serializers.py 100.00% <100.00%> (ø)
karrot/bootstrap/tests/test_api.py 100.00% <ø> (ø)
karrot/subscriptions/api.py 100.00% <100.00%> (ø)
karrot/subscriptions/factories.py 100.00% <100.00%> (ø)
...bscriptions/migrations/0007_webpushsubscription.py 100.00% <100.00%> (ø)
...s/0008_remove_webpushsubscription_auth_and_more.py 100.00% <100.00%> (ø)
...iptions/migrations/0009_delete_pushsubscription.py 100.00% <100.00%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nicksellen nicksellen marked this pull request as ready for review October 11, 2023 11:00
@nicksellen nicksellen merged commit 93298ba into master Oct 11, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant