-
Notifications
You must be signed in to change notification settings - Fork 78
Conversation
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 95.77% 95.81% +0.03%
==========================================
Files 346 351 +5
Lines 13573 13767 +194
Branches 849 854 +5
==========================================
+ Hits 13000 13191 +191
- Misses 457 461 +4
+ Partials 116 115 -1
Continue to review full report at Codecov.
|
c89a3e0
to
f49d0db
Compare
Ok, it works! Although still some more thinking about how to make working with these ranges a bit nicer. I just put a lot of And probably some missing tests to see how updating it to have a nice end date works, etc... ... and then also we realised that part of the use case of having end dates is so that you could have very looooooooooooooooooooooooooooooooong pickups where you can do the pickup at any point, but in that case the useful thing is to be able to mark it as done part way through. The idea would be to add a done field to pickups, and make our existing mechanisms use that too to check for doneness (as opposed to just checking if the date passed and it had collectors), but that should probably be for another PR. So my goal to make this one mergable is to allow the existing frontend to work with minimal changes (but not bother about setting custom end dates - always have them 30 minutes). |
01ad807
to
89ae7b6
Compare
Also refine behaviour to allow setting only the lower bound
89ae7b6
to
b7008b6
Compare
As part of karrot-dev/karrot-frontend#709