This repository has been archived by the owner on May 20, 2024. It is now read-only.
Rename feedback_possible field to is_done #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concept of "feedback possible" still exists seperately
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=========================================
+ Coverage 95.8% 95.8% +<.01%
=========================================
Files 362 363 +1
Lines 13970 13974 +4
Branches 858 858
=========================================
+ Hits 13384 13388 +4
Misses 468 468
Partials 118 118
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=========================================
+ Coverage 95.8% 95.8% +<.01%
=========================================
Files 362 363 +1
Lines 13970 13974 +4
Branches 858 858
=========================================
+ Hits 13384 13388 +4
Misses 468 468
Partials 118 118
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=========================================
+ Coverage 94.99% 95% +<.01%
=========================================
Files 368 369 +1
Lines 14338 14349 +11
Branches 895 895
=========================================
+ Hits 13621 13632 +11
Misses 591 591
Partials 126 126
Continue to review full report at Codecov.
|
nicksellen
changed the title
|
Rebase/renamed so it fits on top of master now. |
tiltec
approved these changes
Feb 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of karrot-dev/karrot-frontend#709 - with the idea that if pickups had a long duration, they might be done part way through, and so would be useful to be able to mark them as done.
This doesn't add the API to mark them as done. Yet.