Sort feedback by activity date #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to created at (previously behaviour) if no activity set
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
- Coverage 58.21% 58.19% -0.02%
==========================================
Files 275 275
Lines 6019 6021 +2
Branches 952 953 +1
==========================================
Hits 3504 3504
- Misses 2514 2516 +2
Partials 1 1
Continue to review full report at Codecov.
|
|
I'll just merge, as it's quite small :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2157
What does this PR do?
The backend was already switched (in karrot-dev/karrot-backend#1044), but the frontend also does sorting, so this PR fixes that... it would fallback to feedback created at date if there is no activity (which would be odd...).