Mail verification, password reset, password change #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authentication is needed for the redirect hook
Tests still fail, I don't know why it doesn't find the route.
TODO: three route tests are skipped, can't get it running
Current coverage is 98.80% (diff: 100%)@@ master #253 diff @@
==========================================
Files 108 115 +7
Lines 1689 1839 +150
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1667 1817 +150
Misses 22 22
Partials 0 0
|
tiltec
pushed a commit
that referenced
this pull request
May 6, 2018
Related issue: #253 * added the correct API endpoint feedback * added the correct API endpoint feedback * corrected API endpoint feedback * Flaked some files * changes with flake8 * cleaned up stored.py * minor changes in url routers * playing with FeedbackSerializer and FeedbackModel * deleted the signal post_feedback_create from signals.py and comment it out in serializers.py as well as some flake8 corrections * upload the changes in signals.py (which should habe been in the previous commit). * fixing bugs * commented out the fields given_by and about in the feedback model for testing purpose * created a first test case, started with another test if the user is not a member of group * added a new test for which has to be written code in serializers.py * added user validation for feedback serializer * removed unneeded code from the serializer and added comments to the tests * added a new test and changed the Feedback validator * bug fixing in test_feedback and playing with FeedbackSerializer * added 1 positive test for displaying feedback as user + uncommented non-working code * flake8 * added migration * flake8 corrections * fixed 1 test with failing non-group member and extended validate_about with code for non-group member * added test that fails if you are not assigned to the pickup * corrected the code in serializers for Feedback, validate_about * minor changes in FeedbackSerializer * fixed the Feedback api test (members / users) * added permission IsMember to FeedbackViewSet and three tests for the method GET (one fails at the moment) * experimented with FeedbackViewSet, tried to raise Http404 error if the user is non-member of group, see comments * turned one failing into passing test and added one more test + more comments in apy.py * added tilmanns code to the serializer * added Feedback.objects.create() to SetUpClass in test_feedback_api.py * added queryset function to api to fix the FeedbackTests for list * more tests for getting single feedback with GET.id for non-user, user, group member and collector * 1 more test for the feedback in the future + comment clean-up * test the feedback model and changed the parameters of the fields weight and comment * removed comments and all unnecessary code * test if feedback can be created if comment to long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
Backend PR: karrot-dev/karrot-backend#208
I will merge the changes at the same time and add the sparkpost secret on the server.