Allow to record no shows when giving feedback #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check if protocol is https: for push notification support - otherwise hangs trying to get service work on http: - refine how the currentGroupIdService detirmines the id - defineStory abstraction to ensure we reset various things
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2680 +/- ##
==========================================
- Coverage 75.94% 75.50% -0.44%
==========================================
Files 375 377 +2
Lines 41011 41387 +376
Branches 2323 2342 +19
==========================================
+ Hits 31145 31249 +104
- Misses 9866 10138 +272
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
- show 0 values in grey - sortable columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend: karrot-dev/karrot-backend#1272
Community forum topic: https://community.karrot.world/t/allow-to-record-no-shows-during-feedback-process/1246
Branch deployment: https://add-no-shows.dev.karrot.world
Ready for review / user testing.