Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public activity series #2701

Merged
merged 4 commits into from Jan 25, 2024
Merged

Add public activity series #2701

merged 4 commits into from Jan 25, 2024

Conversation

nicksellen
Copy link
Member

@nicksellen nicksellen commented Jan 16, 2024

Backend PR karrot-dev/karrot-backend#1285

Currently Karrot supports public activities for individual activities but not public activity series.

This would help as it saves people from having to manually set each activity in a series to public.

TODO

  • review frontend
  • review backend
  • decide how it should series setting should relate to activity setting (maybe only allow setting in the series...?)
  • decide how disabling an activity should work for public activities (hide it publically? or show it as disabled?)

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (e61ce32) 73.91% compared to head (34919e7) 73.72%.

Files Patch % Lines
src/groupInfo/pages/PublicActivitiesEmbed.vue 0.00% 131 Missing ⚠️
src/activities/components/ActivityEdit.vue 55.55% 4 Missing ⚠️
src/groupInfo/pages/GroupPreview.vue 66.66% 2 Missing ⚠️
src/activities/pages/PublicActivity.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2701      +/-   ##
==========================================
- Coverage   73.91%   73.72%   -0.19%     
==========================================
  Files         404      406       +2     
  Lines       44096    44309     +213     
  Branches     2451     2455       +4     
==========================================
+ Hits        32593    32668      +75     
- Misses      11503    11641     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicksellen nicksellen merged commit 3b4e273 into master Jan 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant