This repository has been archived by the owner on May 20, 2024. It is now read-only.
Increase default activity page size to 20 #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a group has a lot of activities at the same start time it can cause not all of them to be returned. Increasing the page size somewhat mitigates the effect but it really needs to be resolved in the DRF CursorPagination.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2712 +/- ##
==========================================
- Coverage 73.69% 73.67% -0.02%
==========================================
Files 404 404
Lines 44225 44236 +11
Branches 2440 2449 +9
==========================================
Hits 32593 32593
- Misses 11632 11643 +11 ☔ View full report in Codecov by Sentry. |
nicksellen
added a commit
that referenced
this pull request
Mar 26, 2024
Some material icons were being wrongly detected as font-awesome ones e.g. "fastfood" Reviewed-on: https://codeberg.org/karrot/karrot-frontend/pulls/2712 Co-authored-by: Nick Sellen <git@nicksellen.co.uk> Co-committed-by: Nick Sellen <git@nicksellen.co.uk>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a full fix, but slightly improves the situation for now.
The problem is that we order activities by a column that is not unique-enough, see this discussion encode/django-rest-framework#7888