Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed preconnect template string syntax #1

Merged

Conversation

amoshydra
Copy link
Contributor

@amoshydra amoshydra commented Oct 3, 2021

Summary

Change preconnect string syntax to use template string so that matomoUrl can be correctly injected into the preconnect link element

Related issue

'${matomoUrl}' is not a template string. The plugin will inject a literal "${matomoUrl}" value into the link tag

How is this tested?

Tested locally in a docusaurus project using yarn link with config:

matomo: {
  matomoUrl: 'https://your.matomo.instance/',
  siteId: 'ID',
},

Before fix

image

After fix

image

@karser
Copy link
Owner

karser commented Oct 4, 2021

Good catch, thank you @amoshydra !

@karser karser merged commit adfefb6 into karser:main Oct 4, 2021
@amoshydra amoshydra deleted the fix-preconnect-template-string-syntax branch October 4, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants