Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] orgTag should also define the preview-list #205

Closed
wellemut opened this issue Mar 25, 2024 · 5 comments · Fixed by #206
Closed

[BUG] orgTag should also define the preview-list #205

wellemut opened this issue Mar 25, 2024 · 5 comments · Fixed by #206
Assignees
Labels
0 bug Something isn't working
Projects

Comments

@wellemut
Copy link
Member

wellemut commented Mar 25, 2024

Bug

Unaproved changes should never be visible on a map with activated orgTag-mode!

This map has the orgTag mode activated (defined by &orgTag=hessenwillsmessen in the URL) https://www.kartevonmorgen.org/m/hessenwillsmessen?c=50.6142%2C8.3633&z=9.46&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=&search=test

The Test-Entry and the word "Test" in the description of the backery got never approved in the clearance-center. But still it is visibel:
grafik

When you click on the entry, the detailed view is correct as it shows no "Test" in the description: https://www.kartevonmorgen.org/m/hessenwillsmessen/e/3fada349903f4d129f6cd918f67094c9?c=50.6142%2C8.3633&z=9.46&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=&search=test
grafik

Opening the test entry does not show anything, which is basically correct, because it is not allowed to show someting. But the entry should not displayed on the map as a dot and not in the list, so no user should be able to click on it.
grafik

Expected behavior

On the old Frontend you see the correct behavior: The test entry is not visible at all and the "Test" in the backery descritpion does not appear:
https://v0.kartevonmorgen.org/#/?center=50.616,8.262&zoom=11.00&search=%23hessenwillsmessen%20test&fixedTags=hessenwillsmessen&orgTag=hessenwillsmessen&dropdowns=hessenwillsmessen
grafik

Obviously, you can not open the Test entry, as it is not visible, so no empty white page!

Technical Background

Additional context
This function on the new frontend is highly relvant for HLNUG. They use the clearance-Center to moderate their map, which is embedded on a govermental page. So no unapproved changes on the map should every be visible on a official public website.

@wellemut wellemut added the 0 bug Something isn't working label Mar 25, 2024
@wellemut wellemut self-assigned this Mar 25, 2024
@wellemut wellemut added this to Beauftragt in HLNUG via automation Mar 25, 2024
@wellemut wellemut assigned navid-kalaei and unassigned wellemut Mar 26, 2024
@navid-kalaei
Copy link
Collaborator

fixed and deployed on the dev domain. please test. @wellemut

@wellemut
Copy link
Member Author

@navid-kalaei thank you.
But on
https://dev.kartevonmorgen.org/m/hessenwillsmessen?c=50.5517%2C9.6752&z=16.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=gray

The problem still exists.
This "Test" should not be visible in the result list
Screenshot_20240326-204435~2.png

The detailed view is correctly filtering for an approved version of the entry
Screenshot_20240326-204439~3.png

@navid-kalaei
Copy link
Collaborator

@wellemut I'm confused, which format is correct: orgTag or org_tag? I implemented the org_tag should i change it/

@wellemut
Copy link
Member Author

Perfect @navid-kalaei
It is working now
https://dev.kartevonmorgen.org/m/hessenwillsmessen?c=50.5493%2C9.6724&z=16.00&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=gray

Please create the pull request for @alex0107

navid-kalaei added a commit that referenced this issue Mar 28, 2024
* fix: add the traditional close sidebar button

* Update map.json

Added String for Unsubscribe Mailnotification

* New translations map.json (French)

* New translations map.json (Italian)

* New translations map.json (Dutch)

* Update source file map.json

* fix (#205): send the org_tag to the backend

* fix: change the spelling of org_tag to orgTag

---------

Co-authored-by: Helmut Wolman <helmut@bildungsagenten.com>
Co-authored-by: Map of Tomorrow <105020802+mapoftomorrow@users.noreply.github.com>
@navid-kalaei
Copy link
Collaborator

@wellemut wellemut linked a pull request Apr 1, 2024 that will close this issue
@wellemut wellemut closed this as completed Apr 1, 2024
HLNUG automation moved this from Beauftragt to Done Apr 1, 2024
navid-kalaei added a commit that referenced this issue Apr 18, 2024
* fix: add the traditional close sidebar button

* Update map.json

Added String for Unsubscribe Mailnotification

* New translations map.json (French)

* New translations map.json (Italian)

* New translations map.json (Dutch)

* Update source file map.json

* fix (#205): send the org_tag to the backend

* fix: change the spelling of org_tag to orgTag

* feat: increase the timeout interval for the get config

---------

Co-authored-by: Helmut Wolman <helmut@bildungsagenten.com>
Co-authored-by: Map of Tomorrow <105020802+mapoftomorrow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 bug Something isn't working
Projects
HLNUG
Done
Development

Successfully merging a pull request may close this issue.

2 participants