New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] orgTag should also define the preview-list #205
Comments
fixed and deployed on the dev domain. please test. @wellemut |
@navid-kalaei thank you. The problem still exists. The detailed view is correctly filtering for an approved version of the entry |
@wellemut I'm confused, which format is correct: |
Perfect @navid-kalaei Please create the pull request for @alex0107 |
* fix: add the traditional close sidebar button * Update map.json Added String for Unsubscribe Mailnotification * New translations map.json (French) * New translations map.json (Italian) * New translations map.json (Dutch) * Update source file map.json * fix (#205): send the org_tag to the backend * fix: change the spelling of org_tag to orgTag --------- Co-authored-by: Helmut Wolman <helmut@bildungsagenten.com> Co-authored-by: Map of Tomorrow <105020802+mapoftomorrow@users.noreply.github.com>
@wellemut @alex0107 created a new release of v1.2.1 https://github.com/kartevonmorgen/kartevonmorgen.ts/releases/tag/1.2.1 |
* fix: add the traditional close sidebar button * Update map.json Added String for Unsubscribe Mailnotification * New translations map.json (French) * New translations map.json (Italian) * New translations map.json (Dutch) * Update source file map.json * fix (#205): send the org_tag to the backend * fix: change the spelling of org_tag to orgTag * feat: increase the timeout interval for the get config --------- Co-authored-by: Helmut Wolman <helmut@bildungsagenten.com> Co-authored-by: Map of Tomorrow <105020802+mapoftomorrow@users.noreply.github.com>
Bug
Unaproved changes should never be visible on a map with activated orgTag-mode!
This map has the orgTag mode activated (defined by &orgTag=hessenwillsmessen in the URL) https://www.kartevonmorgen.org/m/hessenwillsmessen?c=50.6142%2C8.3633&z=9.46&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=&search=test
The Test-Entry and the word "Test" in the description of the backery got never approved in the clearance-center. But still it is visibel:
When you click on the entry, the detailed view is correct as it shows no "Test" in the description: https://www.kartevonmorgen.org/m/hessenwillsmessen/e/3fada349903f4d129f6cd918f67094c9?c=50.6142%2C8.3633&z=9.46&tag=hessenwillsmessen&orgTag=hessenwillsmessen&mapColorMode=&search=test
Opening the test entry does not show anything, which is basically correct, because it is not allowed to show someting. But the entry should not displayed on the map as a dot and not in the list, so no user should be able to click on it.
Expected behavior
On the old Frontend you see the correct behavior: The test entry is not visible at all and the "Test" in the backery descritpion does not appear:
https://v0.kartevonmorgen.org/#/?center=50.616,8.262&zoom=11.00&search=%23hessenwillsmessen%20test&fixedTags=hessenwillsmessen&orgTag=hessenwillsmessen&dropdowns=hessenwillsmessen
Obviously, you can not open the Test entry, as it is not visible, so no empty white page!
Technical Background
The correct request to fetch all entries in a bbox with orgTag would be: https://api.ofdb.io/v0/search?text=#hessenwillsmessen test&categories=2cd00bebec0c48ba9db761da48678134,c2dc278a2d6a4b9b8a50cb606fc017ed,77b3c33a92554bcf8e8c2c86cedd6f6f&bbox=50.48634732684517,7.822952270507813,50.745580217132755,8.701858520507814&limit=250&org_tag=hessenwillsmessen
But the new front-end does not add the orgTag to the api Call: https://api.ofdb.io/v0/search?bbox=50.23572332598048,7.0853700020742325,50.9895922827563,9.641181067676344&text=test #hessenwillsmessen&categories=2cd00bebec0c48ba9db761da48678134,77b3c33a92554bcf8e8c2c86cedd6f6f
Additional context
This function on the new frontend is highly relvant for HLNUG. They use the clearance-Center to moderate their map, which is embedded on a govermental page. So no unapproved changes on the map should every be visible on a official public website.
The text was updated successfully, but these errors were encountered: