Minimum changes needed for API v2

[ClaytonJY]

@karthik figured it'd be nice to have a list in one place. I think if we address all the v1 endpoints one by one, that should make sure we cover all our bases?

I'll start by listing them all then start going through the migration guide to determine which are straightforward and which require more effort.

From grep -r '/1/' ./:

• ./R/drop_auth.R: authorize = "https://www.dropbox.com/1/oauth2/authorize",
• ./R/drop_auth.R: access = "https://api.dropbox.com/1/oauth2/token"
• ./R/drop_dir.R: metadata_url <- "https://api.dropbox.com/1/metadata/auto/"
• ./R/drop_search.R: search_url <- "https://api.dropbox.com/1/search/auto/"
• ./R/drop_delta.R: delta_url <- "https://api.dropbox.com/1/delta"
• ./R/drop_upload.R: put_url <- "https://api-content.dropbox.com/1/files_put/auto/"
• ./R/drop_file_ops.R: move_url <- "https://api.dropbox.com/1/fileops/copy"
• ./R/drop_file_ops.R: move_url <- "https://api.dropbox.com/1/fileops/move"
• ./R/drop_file_ops.R: create_url <- "https://api.dropbox.com/1/fileops/delete"
• ./R/drop_file_ops.R: create_url <- "https://api.dropbox.com/1/fileops/create_folder"
• ./R/drop_shared.R: share_url <- "https://api.dropbox.com/1/shares/auto/"
• ./R/drop_history.R: rev_url <- "https://api.dropbox.com/1/revisions/auto/"
• ./R/drop_acc.R: url <- "https://api.dropbox.com/1/account/info"
• ./R/drop_get.R: get_url <- "https://api-content.dropbox.com/1/files/auto/"
• ./R/drop_media.R: media_url <- "https://api.dropbox.com/1/media/auto/"

[ClaytonJY]

Tried to add these to the milestone instead, but that didn't really work. Could be separate issues but ugh that's a lot of issues.

[scheidec]

More specific details on changes for v2:

• Minimum changes needed for API v2:
  • From grep -r '/1/' ./:

    •  ./R/drop_auth.R: authorize = "https://www.dropbox.com/1/oauth2/authorize"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_auth.R
      • Change from v1: /1/oauth2/authorize to v2: /oath2/authorize
      • V1 docs: https://www.dropbox.com/developers-v1/core/docs#oa2-authorize
      • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#oauth2-authorize
      • Only the path has changed, fixed in PR Update endpoints for oauth2. #75

    •  ./R/drop_auth.R: access = "https://api.dropbox.com/1/oauth2/token"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_auth.R
      • Change from v1: /1/oauth2/token to v2: /oauth2/authorize
      • V1 docs: https://www.dropbox.com/developers-v1/core/docs#oa2-token
      • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#oauth2-token
      • Only the path has changed, fixed in PR Update endpoints for oauth2. #75

    •  ./R/drop_dir.R: metadata_url <- "https://api.dropbox.com/1/metadata/auto/"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_dir.R
      • Change from v1: /1/metadata to v2: /2/files/get_metadata
      • Parameters, return values, and metadata have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#metadata
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-get_metadata
        • Metadata mapping: https://www.dropbox.com/developers/reference/migration-guide#metadata-mapping
          • bytes -> size
          • modified -> server_modified
          • mime_type and root are no longer available in v2
          • is_dir -> check if .tag=“folder”

    •  ./R/drop_search.R: search_url <- "https://api.dropbox.com/1/search/auto/"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_search.R
      • Change from v1: /1/search to v2: /2/files/search
      • Return values, metadata have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#search
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-search
        • Metadata mapping: https://www.dropbox.com/developers/reference/migration-guide#metadata-mapping
          • modifier is now sharing_info/modified_by
            • So maybe change to zz <- lapply(results, function(t) { t$sharing_info$modified_by = NULL; t })

    • ./R/drop_delta.R: delta_url <- "https://api.dropbox.com/1/delta"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_delta.R
      • Change from v1: /1/delta to v2: /2/files/list_folder (with recursive=true)
      • Parameters, return values, and metadata have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#delta
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-list_folder
          • path_prefix, locale, and cursor are no longer parameters in v2
          • changes to cursor? Returned cursor makes calls to /2/files/list_folder/continue
        • Metadata mapping: https://www.dropbox.com/developers/reference/migration-guide#metadata-mapping

    • ./R/drop_upload.R: put_url <- "https://api-content.dropbox.com/1/files_put/auto/" 

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_upload.R
      • Change from v1: /1/files_put to v2: /2/files/upload
      • Parameters, return values, metadata have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#files_put
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-upload
          • ‘Overwrite’ is now part of the v2 ‘mode’ parameter, which lets you specify “overwrite”, “add”, or “update” for file conflicts
        • Metadata mapping: https://www.dropbox.com/developers/reference/migration-guide#metadata-mapping

    • ./R/drop_file_ops.R: move_url <- "https://api.dropbox.com/1/fileops/copy"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_file_ops.R
      • Change from v1: /1/fileops/copy to v2 /2/files/copy
      • Return values and metadata have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#fileops-copy
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-copy
          • ‘root’ not available in v2, from_path and to_path have not changed

    •  ./R/drop_file_ops.R: move_url <- "https://api.dropbox.com/1/fileops/move"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_file_ops.R
      • Change from v1: /1/fileops/move to v2: /2/files/move
      • Return values and metadata have changed
        • ‘root’ not available in v2, from_path and to_path have not changed

    •  ./R/drop_file_ops.R: create_url <- "https://api.dropbox.com/1/fileops/delete"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_file_ops.R
      • Change from v1: /1/fileops/delete to /2/files/delete
      • Return values and metadata have changed
        • ‘root’ not available in v2, ‘path’ has not changed

    •  ./R/drop_file_ops.R: create_url <- "https://api.dropbox.com/1/fileops/create_folder"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_file_ops.R
      • Change from v1: /1/fileops/create_folder to v2: /2/files/create_folder
      • Return values and metadata have changed
        • ‘root’ not available in v2, ‘path’ has not changed

    •  ./R/drop_shared.R: share_url <- "https://api.dropbox.com/1/shares/auto/"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_file_ops.R
      • Change from v1: /1/shares to v2: /2/sharing/create_shared_link_with_settings
      • Parameters and return values have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#shares
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#sharing-create_shared_link_with_settings
          • ‘locale’ and ‘short_url’ are no longer parameters, now just ‘path’ and ‘settings’ are parameters

    •  ./R/drop_history.R: rev_url <- "https://api.dropbox.com/1/revisions/auto/"

      • https://github.com/karthik/rdrop2/blob/master/R/drop_history.R
      • Change from v1: /1/revisions to v2: /2/files/list_revisions
      • Return values and metadata have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#revisions
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-list_revisions
          • No reference of any return values in script as is

    •  ./R/drop_acc.R: url <- "https://api.dropbox.com/1/account/info"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_acc.R
      • Change from v1: /1/account/info to v2: /2/users/get_current_account
      • Parameters and return values have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#account-info
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#users-get_current_account
          • No reference to any parameters or return values in script as is
          • HTTP request method changed from GET in v1 to POST in v2

    •  ./R/drop_get.R: get_url <- "https://api-content.dropbox.com/1/files/auto/"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_get.R
      • Change from v1: /1/files to v2: /2/files/download
      • Parameters have changed
        • V1 docs: https://www.dropbox.com/developers-v1/core/docs#files-GET
        • V2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-download
          • ‘rev’ is now deprecated

    •  ./R/drop_media.R: media_url <- "https://api.dropbox.com/1/media/auto/"

      • Code: https://github.com/karthik/rdrop2/blob/master/R/drop_media.R
      • Change from v1: /1/media to v2: /2/files/get_temporary_link
      • Parameters, return values, metadata have changed
        * V1 docs: https://www.dropbox.com/developers-v1/core/docs#media
        * v2 docs: https://www.dropbox.com/developers/documentation/http/documentation#files-get_temporary_link
        * ‘locale’ no longer a parameter

[ClaytonJY]

Closing as this has been broken into one-issue-per-endpoint.