Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Preview on iPad [$450] #1254

Closed
5 of 6 tasks
oadam opened this issue Jun 13, 2018 · 7 comments
Closed
5 of 6 tasks

PDF Preview on iPad [$450] #1254

oadam opened this issue Jun 13, 2018 · 7 comments

Comments

@oadam
Copy link
Contributor

oadam commented Jun 13, 2018

Hi and thanks a lot for this plugin !
I'm having an issue when previewing pdfs on ipads

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest master branch of bootstrap-fileinput.
  • This is not an usage question. I confirm having read the plugin documentation and demos.
  • This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
  • I have attempted to find the simplest possible steps to reproduce the issue.
  • I have included a failing test as a pull request (Optional).

Steps to reproduce the issue

  1. Navigate to http://plugins.krajee.com/file-basic-usage-demo with an ipad
  2. Select a pdf and check the preview
  3. See that the preview is not scrollable and has a weird aspect ratio

This is a well known issue with pdf embedding on ipad (https://stackoverflow.com/questions/15854537/make-embedded-pdf-scrollable-in-ipad/).

Seems like the easiest workaround would be using https://mozilla.github.io/pdf.js/ when previewing on ipad.

What do you think ?


Did you help close this issue? Go claim the $450 bounty on Bountysource.

@kartik-v
Copy link
Owner

Am open to suggestions. Feel free to add a PR if you wish.

@oadam
Copy link
Contributor Author

oadam commented Jun 19, 2018

Since this is a major annoyance for my company, we'd be ready to sponsor this development.
@kartik-v Is this something you (or someone you know) would be open to ?

@oadam
Copy link
Contributor Author

oadam commented Jun 19, 2018

an alternative would be opening a bounty on https://www.bountysource.com/

@kartik-v kartik-v changed the title pdf preview on ipad PDF Preview on iPad Jun 19, 2018
@kartik-v
Copy link
Owner

kartik-v commented Jun 19, 2018

Thanks - I have enabled bountysource. Let's see some bounties posted to start. I will take it up personally if I get a bit of time as well.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@oadam
Copy link
Contributor Author

oadam commented Jun 20, 2018

Thank you for setting up bountysource.
I've created a $300 bounty on the issue 👍

@kartik-v
Copy link
Owner

kartik-v commented Jun 20, 2018

Thanks @denim2x I had started this as well and will be posting a fix soon.

@kartik-v kartik-v changed the title PDF Preview on iPad PDF Preview on iPad [$450] Jun 21, 2018
@kartik-v
Copy link
Owner

kartik-v commented Jun 21, 2018

This has been fixed via the commit 7ee4578. The following are the new properties available in the plugin (refer the updated plugin docs and demos):

New plugin options

Updated demo for PDF rendering

NOTE:
You must install the PDF JS Viewer library on your same web server as the file input as mentioned in the docs. Then configure pdfRendererUrl to point to this PDF JS viewer library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants