More correct validation of previewContentTemplates
#1276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2018 09:08
…elp you to avoid bugs with previews in mobile version
|
Related to enhancement #1254. Will update over this. |
kartik-v
changed the title
previewContentTemplates
kartik-v
changed the title
previewContentTemplatespreviewContentTemplates to init templates instead of internal defaults
kartik-v
changed the title
previewContentTemplates to init templates instead of internal defaultspreviewContentTemplates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This pull request includes a
Changes
This changes will allow you to configure preview templates. On small screens, for example on Safari in IPhone 5SE, fileinput has problems with showing of pdf-files previews. These previews are located on
embed-container. This problems disappear after transfering fromembedtoiframe. That's why i thought that flexibility of this option is necessary.Related Issues
If this is related to an existing ticket, include a link to it as well.