Filesize is compared in KB (= 1000 Bytes) but displayed in KiB (= 1024 Bytes).

[reckert]

Prerequisites

• I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
• The issue still exists against the latest master branch of bootstrap-fileinput.
• This is not an usage question. I confirm having read the plugin documentation and demos.
• This is not a general programming / coding question. (Those should be directed to the webtips Q & A forum).
• I have attempted to find the simplest possible steps to reproduce the issue.

Steps to reproduce the issue

1. Create a simple file upload form. Set the maxFileSize to 100 (KB/KiB?). Open it in your browser (even from the file system).

	$(document).ready(function() {
		$("#input-upload").fileinput({
			maxFileSize: 100
		});
	});

2. Or try it here: https://jsfiddle.net/1neawk5x/
3. Drop a file with a size of (i.e.) 101974 bytes (= 99.58 KiB = 101.97 KB)
4. Look at the file size in the preview and in the error message

Expected behavior and actual behavior

The preview shows that the size of the file is 99.5 KB. That is identical to the value shown in Ms Windows file explorer.
The error message reports "File "xxxx" (101.97 KB) exceeds maximum allowed upload size of 100 KB.

I was expecting no error message to occur / both values to be the same.

When a file is selected, its size is converted into KB by dividing by 1000.

bootstrap-fileinput/js/fileinput.js

Line 5379 in 1a97ee0

caption = self._getFileName(file, ''), fileSize = (file && file.size || 0) / 1000,

This value is later compared to maxFileSize, so it can be assumed that maxFileSize holds the maximum size in KB (1000 bytes), too

bootstrap-fileinput/js/fileinput.js

Line 5447 in 1a97ee0

if (self.maxFileSize > 0 && fileSize > self.maxFileSize) {

The default method to display the size really uses KiB (1024 bytes), though.

bootstrap-fileinput/js/fileinput.js

Line 4139 in 1a97ee0

out = (size / Math.pow(1024, i)).toFixed(2) + ' ' + sizes[i];

That way, the size compared to the maxFileSize property is a different one than the one displayed to the user.

The "iB" units are not frequently used by normal users and several systems (including MS Windows file explorer) calculate in Base2 (1024 bytes) but still show "KB", "MB", etc..
I would suggest to just change the calculation of the file size by changing 1000 to1024 in line 5379 in js/fileinput.js.

Environment

Browsers

• any, tested on Firefox Desktop and Chrome

Operating System

• any, tested on MS Window

Libraries

• jQuery version: 3.6.0
• bootstrap-fileinput version: 5.2.2

Isolating the problem

• This bug happens on the plugin demos page
• The bug happens consistently across all tested browsers
• This bug happens when using bootstrap-fileinput without other plugins

[kartik-v]

Fixed via the latest commit, New property bytesToKB has been introduced (and can be modified if needed) which defaults to 1024 and is used for conversion.