Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resumable upload error: fix displaying errors #1688

Closed
wants to merge 1 commit into from

Conversation

pigator
Copy link

@pigator pigator commented Feb 26, 2021

When resumableUploadOptions.skipErrorsAndProceed was true and multiple errors could occur during resumable upload, errors were discarded (reset) and only the last error would be displayed. Now all the errors are displayed if resumableUploadOptions.skipErrorsAndProceed is set to true.

Scope

This pull request includes a

  • Bug fix
  • New feature
  • Translation

Changes

The following changes were made

  • When doing resumable upload and if resumableUploadOptions.skipErrorsAndProceed is set to true, multiple errors are displayed and not only the last one

Related Issues

#1687

bs-fileupload-20210226-01

When resumableUploadOptions.skipErrorsAndProceed was true and multiple errors could occur during resumable upload, errors were discarded (reset) and only the last error would be displayed. Now all the errors are displayed if resumableUploadOptions.skipErrorsAndProceed is set to true.
@kartik-v
Copy link
Owner

Thanks - will need a bit of modification for all conditions to be correct. Will update over the PR.

@kartik-v
Copy link
Owner

A new boolean property resumableUploadOptions.retainErrorHistory has been added which will allow to control whether one wants to show history of all previous errors during resumable uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants